Added scrolling to security release #77
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soupslurpr
suggested changes
Jan 22, 2026
Member
soupslurpr
left a comment
soupslurpr
left a comment
There was a problem hiding this comment.
Looks pretty good, just needs some minor refactors!
app/src/main/kotlin/app/grapheneos/info/ui/releases/ReleasesViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/app/grapheneos/info/ui/releases/ReleasesViewModel.kt
Outdated
Show resolved
Hide resolved
…:DirkBaumeister/grapheneos-Info into feature/added-scroll-to-security-release
Author
Thank you very much for your feedback! I have optimized my code and hope that it is fine now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned here: #76 currently, if the security release is used (and the release version of the device ends with a 1 instead of a 0) the info screen for new releases always stays at the top and does not scroll to the currently installed release, like it did before.
With this pull request this is fixed the following way:
If by the exact version of the device no entry in the atom rss feed title can be found, a second matching for the index of the current release version takes place. But this time, the last character of the release number is replaced by the next higher digit (0 gets a 1, 2 gets a 3, 4 gets a 5 and so on for any possible "standard" and security release combo).
This way, even if there are multiple releases in one day (Which would result in releases with 02, 04, 06 etc at the end for "standard" releases and its corresponding security releases 01, 03, 05, 07 etc...), it would still match this releases first before it even tries to find it by a security release version number.